-
Notifications
You must be signed in to change notification settings - Fork 235
specify acl for S3 objects #412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Updated tests in second commit. tests pass locally for me. |
sbkok
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a few style suggestions, nothing major.
Thanks for contributing this.
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/python/s3.py
Outdated
Show resolved
Hide resolved
...lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/python/tests/test_s3.py
Outdated
Show resolved
Hide resolved
...lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/python/tests/test_s3.py
Outdated
Show resolved
Hide resolved
Done! As an alternative, may I recommend switching to an opinionated formatting tool, such as black? Formatting can then be automated as part of the PR process. Co-authored-by: Simon Kok <[email protected]>
|
Done! |
|
Actually, I am working on adding automated formatting. So most likely around releasing 3.2.0 I will add that to the repository. |
sbkok
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
sbkok
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
javydekoning
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks.
Allows to specify the object ACL when using the S3 module. Uses
privateas the default, which was the implicit default before.This allows to utilize different ACLs, like
bucket-owner-full-controlwhich is useful when operating with shared files.Example:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.