Skip to content

Conversation

@sbkok
Copy link
Collaborator

@sbkok sbkok commented Dec 8, 2021

Why?

When you run into errors deploying the latest version of ADF, it was not easy to enable the debug level, as those used to be hard coded and non-configurable.

Additionally, the admin guide does not provide the required information to trace issues independently.

What?

This change introduces a Log Level parameter to the SAR deployment process.
Allowing the administrators to deploy ADF with a specific Log Level such as DEBUG directly from the SAR.

It also explains how to troubleshoot ADF deployments to the admin guide.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

sbkok added 2 commits December 8, 2021 18:33
**Why?**

When you run into errors deploying the latest version of ADF, it was not
easy to enable the debug level, as those used to be hard coded and
non-configurable.

**What?**

This change introduces a Log Level parameter to the SAR deployment
process. Allowing the administrators to deploy ADF with a specific Log
Level such as DEBUG directly from the SAR.
@sbkok sbkok added the enhancement New feature or request label Dec 8, 2021
@sbkok sbkok added this to the v3.2.0 milestone Dec 8, 2021
Nr18
Nr18 previously approved these changes Dec 9, 2021
Copy link
Contributor

@Nr18 Nr18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, found one block quote error in the documentation. That will break the styling of markdown.

Copy link
Collaborator

@thomasmcgannon thomasmcgannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@StewartW StewartW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sbkok sbkok merged commit cd879cb into awslabs:master Dec 10, 2021
@sbkok sbkok deleted the feature/set-log-level-on-deploy branch December 10, 2021 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants