Reducing the number of IAM API calls made during enable cross-account… #408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbkok
requested changes
Dec 10, 2021
Collaborator
sbkok
left a comment
sbkok
left a comment
There was a problem hiding this comment.
Minor suggestions only. Thanks for contributing this improvement!
...bootstrap_repository/adf-bootstrap/deployment/lambda_codebase/enable_cross_account_access.py
Show resolved
Hide resolved
...ambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/python/tests/test_iam.py
Show resolved
Hide resolved
...ambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/python/tests/test_iam.py
Show resolved
Hide resolved
Co-authored-by: Simon Kok <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… access
Issue #, if available: N/A
Description of changes:
I've changed the logic ever so slightly so that when enabling cross account access, it reduces the number of API calls in the deployment account. Currently it will update the IAM policies per region (3 x Number of regions), meaning that it increases the chances of being throttled.
This changes it to 3 API calls per account (or how many role/policy mappings are passed in).
I've tried to make the change backwards compatible, just incase customers have downstream modifications to this lambda
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.