Fix: Deployment Account Step Function Time outs #401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored state machine slightly to move account iteration logic into a map, lambda function then does region checks for each account as before. No change to function logic bar removing the for account_id in account_ids loop.
sbkok
requested changes
Nov 8, 2021
Collaborator
sbkok
left a comment
sbkok
left a comment
There was a problem hiding this comment.
Thanks for working on this issue.
Could you look at the attached comments?
...bootstrap_repository/adf-bootstrap/deployment/lambda_codebase/enable_cross_account_access.py
Outdated
Show resolved
Hide resolved
src/lambda_codebase/initial_commit/bootstrap_repository/adf-bootstrap/deployment/global.yml
Outdated
Show resolved
Hide resolved
src/lambda_codebase/initial_commit/bootstrap_repository/adf-bootstrap/deployment/global.yml
Outdated
Show resolved
Hide resolved
dsudduth
approved these changes
Nov 9, 2021
Contributor
dsudduth
left a comment
dsudduth
left a comment
There was a problem hiding this comment.
The latest round of changes look great! Thank you for the fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #400
Description of changes:
Refactored state machine slightly to move account iteration logic into
a map, lambda function then does region checks for each account as before.
No change to function logic bar removing the for account_id in account_ids
loop.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.