Adding support for account-specific SCP deployment. #395
Conversation
...lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/python/organizations.py
Outdated
Show resolved
Hide resolved
sbkok
left a comment
sbkok
left a comment
There was a problem hiding this comment.
Thanks for adding these changes @srabidoux.
Could you write tests for the functionality you added? And could you also document the functionality in the docs/admin-guide.md?
...lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/python/organizations.py
Outdated
Show resolved
Hide resolved
...lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/python/organizations.py
Show resolved
Hide resolved
...lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/python/organizations.py
Show resolved
Hide resolved
...lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/python/organizations.py
Outdated
Show resolved
Hide resolved
sbkok
left a comment
sbkok
left a comment
There was a problem hiding this comment.
Thank you for making these changes so quickly.
Could you update the documentation to describe how ADF users/admins should use this feature?
|
I updated the admin-guide documentation to explain how account-specific SCPs can be applied. Let me know what you think. |
sbkok
left a comment
sbkok
left a comment
There was a problem hiding this comment.
Thanks for adding the documentation and following up quickly.
A few minor polishing comments below. Almost ready to get it merged! Good job.
Co-authored-by: Simon <[email protected]>
Co-authored-by: Simon <[email protected]>
Co-authored-by: Simon <[email protected]>
|
@sbkok I went ahead and accepted all of your suggestions. Thanks! |
sbkok
left a comment
sbkok
left a comment
There was a problem hiding this comment.
LGTM, thank you for implementing this!
3 participants
Description of changes:
get_organization_map() in organizations.py is modified to include individual account names as well as OUs. This allows account-specific SCPs to be deployed using the same method as OU-level SCPs in ADF.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.