Skip to content

Refactoring Account management to use a step function #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbkok merged 22 commits into from
Nov 22, 2021
Merged

Refactoring Account management to use a step function #394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
c259bc8
Refactoring to use a step function
StewartW Oct 15, 2021
1c7f6d6
Consistent retries, fixing tests
StewartW Oct 19, 2021
1ed6599
Merge branch 'master' of github.com:awslabs/aws-deployment-framework …
StewartW Nov 12, 2021
7cfd5a7
Code Review comments
StewartW Nov 16, 2021
c0f60a2
Apply suggestions from code review
StewartW Nov 16, 2021
cf57427
Adding in global variables
StewartW Nov 16, 2021
a4607cb
Merge branch 'refactor/account-processing' of github.com:StewartW/aws…
StewartW Nov 16, 2021
166c6eb
reducing permissions, fixing policy names
StewartW Nov 16, 2021
2f04bea
Update src/lambda_codebase/account_processing/register_account_for_su…
StewartW Nov 16, 2021
873b7a7
Update src/lambda_codebase/account_processing/requirements.txt
StewartW Nov 16, 2021
7495fd3
Switching to logger rather than print
StewartW Nov 17, 2021
f924ce0
Merge branch 'refactor/account-processing' of github.com:StewartW/aws…
StewartW Nov 17, 2021
9ba3671
Merge branch 'master' of github.com:awslabs/aws-deployment-framework …
StewartW Nov 18, 2021
a8ca162
Code Review comments
StewartW Nov 18, 2021
bcde862
Update src/account_processing.yml
StewartW Nov 18, 2021
886a639
Indentation, new-line, and line-length fixes
sbkok Nov 18, 2021
49f7233
Fix typos in account processing
sbkok Nov 18, 2021
e95d944
Ensure returned objects are clones from input when modified
sbkok Nov 18, 2021
99ea0ee
Refactor Delete Default VPC logic
sbkok Nov 18, 2021
06181c5
Refactor Process Account Files logic
sbkok Nov 18, 2021
f9dab60
Refactor from Id to account_id in Step Function logic
sbkok Nov 18, 2021
df025ae
Merge branch 'master' into refactor/account-processing
sbkok Nov 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ master-deploy.yml
.pytest_cache
shared_layer.zip
.aws-sam
samconfig.toml
pipeline.json
template-sam.yml
deploy.sh
Expand Down
9 changes: 8 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,18 @@ init:
test:
# Run unit tests
pytest src/lambda_codebase/account -vvv -s -c src/lambda_codebase/account/pytest.ini
pytest src/lambda_codebase/account_processing -vvv -s -c src/lambda_codebase/account_processing/pytest.ini
pytest src/lambda_codebase/initial_commit/bootstrap_repository -vvv -s -c src/lambda_codebase/initial_commit/bootstrap_repository/pytest.ini
pytest src/lambda_codebase/initial_commit/bootstrap_repository/adf-bootstrap/deployment/lambda_codebase -vvv -s -c src/lambda_codebase/initial_commit/bootstrap_repository/adf-bootstrap/deployment/lambda_codebase/pytest.ini
pytest src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/python -vvv -s -c src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/python/pytest.ini
pytest src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk -vvv -s -c src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/pytest.ini
pytest src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared -vvv -s -c src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/pytest.ini
lint:
# Linter performs static analysis to catch latent bugs
find src/ -iname "*.py" | xargs pylint --rcfile .pylintrc
find src/ -iname "*.py" -not -path "src/.aws-sam/*" | xargs pylint --rcfile .pylintrc

build:
sam build -u

deploy:
sam deploy --capabilities CAPABILITY_NAMED_IAM CAPABILITY_AUTO_EXPAND
Loading