Feature 372: Pipeline Triggers #392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
StewartW
commented
Oct 22, 2021
.../initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_codepipeline.py
Outdated
Show resolved
Hide resolved
..._commit/bootstrap_repository/adf-build/shared/cdk/cdk_stacks/tests/test_pipeline_creation.py
Show resolved
Hide resolved
sbkok
reviewed
Nov 8, 2021
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/schema_validation.py
Show resolved
Hide resolved
sbkok
requested changes
Nov 10, 2021
Collaborator
sbkok
left a comment
sbkok
left a comment
There was a problem hiding this comment.
Thanks for adding the docs. I have left a few review comments, please reach out to me if you need support or if anything is unclear.
.../initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_codepipeline.py
Outdated
Show resolved
Hide resolved
.../initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_stacks/adf_default_pipeline.py
Outdated
Show resolved
Hide resolved
..._commit/bootstrap_repository/adf-build/shared/cdk/cdk_stacks/tests/test_pipeline_creation.py
Show resolved
Hide resolved
..._commit/bootstrap_repository/adf-build/shared/cdk/cdk_stacks/tests/test_pipeline_creation.py
Outdated
Show resolved
Hide resolved
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/schema_validation.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Simon <[email protected]>
Co-authored-by: Simon <[email protected]>
Co-authored-by: Simon <[email protected]>
…ild/shared/cdk/cdk_stacks/tests/test_pipeline_creation.py Co-authored-by: Simon <[email protected]>
…ild/shared/schema_validation.py Co-authored-by: Simon <[email protected]>
…ild/shared/cdk/cdk_stacks/tests/test_pipeline_creation.py Co-authored-by: Simon <[email protected]>
sbkok
requested changes
Nov 11, 2021
.../initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_stacks/adf_default_pipeline.py
Outdated
Show resolved
Hide resolved
..._commit/bootstrap_repository/adf-build/shared/cdk/cdk_stacks/tests/test_pipeline_creation.py
Show resolved
Hide resolved
StewartW
force-pushed
the
feature/372
branch
from
27b279a to
38422d6
Compare
StewartW
force-pushed
the
feature/372
branch
from
38422d6 to
4b5eb95
Compare
sbkok
requested changes
Nov 12, 2021
.../initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_codepipeline.py
Outdated
Show resolved
Hide resolved
.../initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_codepipeline.py
Outdated
Show resolved
Hide resolved
.../initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_stacks/adf_default_pipeline.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Simon Kok <[email protected]>
sbkok
requested changes
Nov 17, 2021
.../initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_codepipeline.py
Outdated
Show resolved
Hide resolved
.../initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_codepipeline.py
Outdated
Show resolved
Hide resolved
…ild/shared/cdk/cdk_constructs/adf_codepipeline.py Co-authored-by: Simon Kok <[email protected]>
…ild/shared/cdk/cdk_constructs/adf_codepipeline.py Co-authored-by: Simon Kok <[email protected]>
…ework into feature/372
sbkok
requested changes
Nov 17, 2021
.../initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_stacks/adf_default_pipeline.py
Show resolved
Hide resolved
thomasmcgannon
approved these changes
Nov 17, 2021
Collaborator
thomasmcgannon
left a comment
thomasmcgannon
left a comment
There was a problem hiding this comment.
nice feature! lgtm!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#372
Description of changes:
Updated adf_default_pipeline to be able to add in additional triggers for the CodePipeline.
First one is the customer requested Code Artifact.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.