adding in ability to define CodeCommit artifact format #389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbkok
requested changes
Nov 8, 2021
Collaborator
sbkok
left a comment
sbkok
left a comment
There was a problem hiding this comment.
Thanks for adding this!
A few minor comments, if you could fix those we are good to go.
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/schema_validation.py
Outdated
Show resolved
Hide resolved
..._commit/bootstrap_repository/adf-build/shared/cdk/cdk_stacks/tests/test_pipeline_creation.py
Show resolved
Hide resolved
Co-authored-by: Simon <[email protected]>
…ild/shared/schema_validation.py Co-authored-by: Simon <[email protected]>
sbkok
previously approved these changes
Nov 12, 2021
Collaborator
sbkok
left a comment
sbkok
left a comment
There was a problem hiding this comment.
LGTM, thanks for following up on the review and adding this feature!
sbkok
approved these changes
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#387
Description of changes:
Added in the ability to set the CodeCommit source provider property for output artifact format
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.