Skip to content

Fix specifying tag on CodeBuild repository image to use #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbkok merged 2 commits into from
Jul 22, 2021
Merged

Fix specifying tag on CodeBuild repository image to use #377

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d5599e
Fix specifying tag on CodeBuild repository image to use
sbkok Jul 21, 2021
f24d50e
Merge branch 'master' into fix/codebuild-image-tag
sbkok Jul 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/providers-guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,7 @@ Provider type: `codebuild`.
> pipeline to consume a custom image if required.
> Along with `repository_arn`, we also support a `tag` key which can be used
> to define which image should be used (defaults to `latest`).
> An example of this setup is provided [here](https://github.com/awslabs/aws-deployment-framework/blob/master/docs/user-guide.md#custom-build-images).
- *size* *(String)* **(small|medium|large)** - default: `small`.
> The Compute type to use for the build, types can be found
> [here](https://docs.aws.amazon.com/codebuild/latest/userguide/build-env-ref-compute-types.html).
Expand Down
2 changes: 1 addition & 1 deletion docs/user-guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ pipelines:
provider: codebuild
image:
repository_arn: arn:aws:ecr:region:012345678910:repository/test
tag: latest #optional (and also defaults to latest)
tag: latest # optional (defaults to latest)
targets:
- ...
```
Expand Down
2 changes: 1 addition & 1 deletion ...lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/schema_validation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@
# CodeBuild
CODEBUILD_IMAGE_PROPS = {
"repository_arn": str, # arn:aws:ecr:region:012345678910:repository/test
Optional("tags"): dict,
Optional("tag"): str, # defaults to latest
}
CODEBUILD_PROPS = {
Optional("image"): Or(str, CODEBUILD_IMAGE_PROPS),
Expand Down