Feature: added ability to override the default branch #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbkok
requested changes
Nov 5, 2021
Collaborator
sbkok
left a comment
sbkok
left a comment
There was a problem hiding this comment.
Small change requested.
Other than that, looks good to me.
I wish we could default to main as the branch name. But unfortunately that would not be backward compatible. Something to consider for the next major release.
Thanks for contributing this change.
src/lambda_codebase/initial_commit/bootstrap_repository/example-adfconfig.yml
Outdated
Show resolved
Hide resolved
sbkok
reviewed
Nov 5, 2021
src/lambda_codebase/initial_commit/bootstrap_repository/example-adfconfig.yml
Outdated
Show resolved
Hide resolved
sbkok
approved these changes
Nov 18, 2021
Collaborator
sbkok
left a comment
sbkok
left a comment
There was a problem hiding this comment.
I've pushed the changes requested in the review comments above.
Thanks for delivering this feature @apogorielov!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…pipelines
Issue #, if available:
Description of changes:
Following PR adds ability to override default "master" branch for deployment pipelines using values provided in adfconfig.yml. If parameter is not provided, branch defaults to "master" to remain backward compatibility.
Priority of branch selection:
Parameter is propagated to the deployment accounts using SSM, where later is retrieved and used a part of input generation for pipelines.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.