Improve ADF version references in main template #351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Why?** For each new version of ADF, we need to update the version number in the main template. However, as there are quite a few, it is likely to forget one or search/replace another string that should not have matched. **What?** By adding the version number as a mapping, it can be updated quickly. Reducing the number of times the version is repeated in the template to two. The first usage, in the Serverless Application Repository (SAR) metadata is not able to use intrinsic CloudFormation functions unfortunately. As described in the [SAR Metadata property documentation](https://docs.aws.amazon.com/serverless-application-model/latest/developerguide/serverless-sam-template-publishing-applications-metadata-properties.html).
thomasmcgannon
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
For each new version of ADF, we need to update the version number in the
main template. However, as there are quite a few, it is likely to forget
one or search/replace another string that should not have matched.
What?
By adding the version number as a mapping, it can be updated quickly.
Reducing the number of times the version is repeated in the template to
two.
The first usage, in the Serverless Application Repository (SAR) metadata
is not able to use intrinsic CloudFormation functions unfortunately.
As described in the SAR Metadata property documentation.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.