Skip to content

Conversation

@sbkok
Copy link
Collaborator

@sbkok sbkok commented Apr 9, 2021

Rebased version with fixes of pull request #238, as proposed in the review comments.
Pushing the changes to the same branch was not enabled, hence fixing it with a separate pull request.


Original description:

Issues:

when creating a new account, AWS services are not available for some time and bootstrap pipeline and step function fail
when deleting default VPCs, pipeline fails if a VPC is non-empty and stops to delete default VPC in any other regions.

Description of changes:

This code enables ADF to wait for services enablement and retry.
This code handles exception on non-empty VPC and continues to delete VPCs in other regions.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sbkok sbkok force-pushed the fix/retry-logic-describe-regions branch from c69859a to 322dd3b Compare April 9, 2021 14:18
Copy link

@deltagarrett deltagarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@krisnielander krisnielander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM2

@sbkok sbkok merged commit c54cbf3 into awslabs:master May 20, 2021
@sbkok sbkok deleted the fix/retry-logic-describe-regions branch May 20, 2021 13:49
@sbkok sbkok added this to the v3.2.0 milestone Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants