Fix resolve intrinsic function use in first parameter #336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Why?** A bug prevented the use of the `resolve:` intrinsic function on the first parameter in in the first parameter file. **What?** The parameters were initialized as an empty dictionary. While reading a file that does not exist would return a predefined object instead. The fix uses the later instead of an empty dictionary.
sbkok
added a commit
to sbkok/aws-deployment-framework
that referenced
this pull request
Mar 12, 2021
**Fixes 🐞** * Fix use of the `resolve:` intrinsic function on the first parameter in the parameter files, awslabs#336.
Merged
sbkok
added a commit
that referenced
this pull request
Mar 12, 2021
**Fixes 🐞** * Fix use of the `resolve:` intrinsic function on the first parameter in the parameter files, #336.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
A bug prevented the use of the
resolve:intrinsic function on the first parameter in in the first parameter file.What?
The parameters were initialized as an empty dictionary. While reading a file that does not exist would return a predefined object instead. The fix uses the later instead of an empty dictionary.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.