-
Notifications
You must be signed in to change notification settings - Fork 236
Ability to use codestar sources in deployment map #312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -59,6 +59,18 @@ pipelines: | |
| - path: /banking/testing | ||
| name: fancy-name | ||
|
|
||
| - name: sample-ecs-app | ||
| default_providers: # if we omit build and deploy type we get a default of codebuild as the build and cloudformation as the deploy. if using codecommit, account_id is required | ||
| source: | ||
| provider: codestar | ||
| properties: | ||
| repository: my-ecs-app # Optional, above name property will be used if this is not specified | ||
| owner: github-enterprise-team-org | ||
| codestar_connection_path: /path/to/parameter # The path in AWS Systems Manager Parameter Store that holds the AWS CodeStar Connection arn | ||
| params: | ||
| notification_endpoint: [email protected] | ||
| targets: | ||
| - [ /banking/testing, /banking/production ] | ||
|
|
||
| - name: sample-custom # using a custom pipeline, we can execute code within CodeBuild to perform whichever tasks are required. | ||
| default_providers: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 changes: 37 additions & 0 deletions
37
...e/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_codestar.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| # Copyright 2020 Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| # SPDX-License-Identifier: MIT-0 | ||
|
|
||
| """Construct related to CodeStarConnection Codepipeline Input | ||
| """ | ||
|
|
||
| import os | ||
|
|
||
| from aws_cdk import ( | ||
| aws_codepipeline as _codepipeline, | ||
| core | ||
| ) | ||
|
|
||
| from cdk_constructs.adf_codepipeline import Action | ||
|
|
||
| ADF_DEPLOYMENT_REGION = os.environ["AWS_REGION"] | ||
| ADF_DEPLOYMENT_ACCOUNT_ID = os.environ["ACCOUNT_ID"] | ||
| ADF_DEFAULT_BUILD_TIMEOUT = 20 | ||
|
|
||
|
|
||
| class CodeStar(core.Construct): | ||
| def __init__(self, scope: core.Construct, id: str, map_params: dict, **kwargs): #pylint: disable=W0622 | ||
| super().__init__(scope, id, **kwargs) | ||
| self.source = _codepipeline.CfnPipeline.StageDeclarationProperty( | ||
| name="Source-CodeStar", | ||
| actions=[ | ||
| Action( | ||
| name="source", | ||
| provider="CodeStarSourceConnection", | ||
| owner="AWS", | ||
| category="Source", | ||
| run_order=1, | ||
| map_params=map_params, | ||
| action_name="source" | ||
| ).config | ||
| ] | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a newline above the Properties title here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done