bindings for EC crypto #356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TingDaoK
reviewed
Nov 5, 2025
Comment on lines
140
to
141
| try bufferData.withUnsafeMutableBytes { bufferPointer in | ||
| var buffer = aws_byte_buf_from_empty_array(bufferPointer.baseAddress, bufferSize) |
Contributor
There was a problem hiding this comment.
trivial: for readability, maybe rename bufferPointer so it's not the same from this two different disclosure?
The first one is for digest and the second one is for the buffer to return, right?
Oh, just like the verify functions
Contributor
Author
There was a problem hiding this comment.
yeah, went through the code and updated a bunch of places (original was based on hash impl naming, which we should probably refactor at some point as well)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.