stop packing future variable to avoid tsan data race warnings #741
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
future bitpacks several variables into uint32
https://github.com/awslabs/aws-c-io/blob/main/source/future.c#L54
tsan will complain if those variables are accessed from different threads.
this pr fixes the data race from aws_future_impl_get_result_by_move updating owns_data variable and aws_future_impl_set_error reading is_done, by unpacking the variables.
aws-c-io/source/future.c
Line 219 in 25faa8d
aws-c-io/source/future.c
Line 302 in 25faa8d
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.