Skip to content

Conversation

@waahm7
Copy link
Contributor

@waahm7 waahm7 commented May 21, 2025

Issue #, if available:

Description of changes:

  • iOS cross compile CI is failing in aws-crt-cpp with lint warnings
     /usr/bin/clang -x c -fmessage-length\=0 -fdiagnostics-show-note-include-stack -fmacro-backtrace-limit\=0 -fno-color-diagnostics -Wno-trigraphs -Wno-missing-field-initializers -Wno-missing-prototypes -Wno-return-type -Wno-missing-braces -Wparentheses -Wswitch -Wno-unused-function -Wno-unused-label -Wno-unused-parameter -Wno-unused-variable -Wunused-value -Wno-empty-body -Wno-uninitialized -Wno-unknown-pragmas -Wno-shadow -Wno-four-char-constants -Wno-conversion -Wno-constant-conversion -Wno-int-conversion -Wno-bool-conversion -Wno-enum-conversion -Wno-float-conversion -Wno-non-literal-null-conversion -Wno-objc-literal-conversion -Wshorten-64-to-32 -Wpointer-sign -Wno-newline-eof -Wno-implicit-fallthrough -fstrict-aliasing -Wdeprecated-declarations -Wno-sign-conversion -Wno-infinite-recursion -Wno-comma -Wno-block-capture-autoreleasing -Wno-strict-prototypes -Wno-semicolon-before-method-body -Wall -Wstrict-prototypes -Werror -Wextra -Wno-long-long -Wgnu -Wno-gnu-zero-variadic-macro-arguments @/Users/runner/work/aws-crt-cpp/aws-crt-cpp/aws-crt-cpp/build/aws-crt-cpp/build/aws-c-io.build/RelWithDebInfo-iphoneos/Objects-normal/arm64/7187679823f38a2a940e0043cdf9d637-common-args.resp -MMD -MT dependencies -MF /Users/runner/work/aws-crt-cpp/aws-crt-cpp/aws-crt-cpp/build/aws-crt-cpp/build/aws-c-io.build/RelWithDebInfo-iphoneos/Objects-normal/arm64/nw_socket.d --serialize-diagnostics /Users/runner/work/aws-crt-cpp/aws-crt-cpp/aws-crt-cpp/build/aws-crt-cpp/build/aws-c-io.build/RelWithDebInfo-iphoneos/Objects-normal/arm64/nw_socket.dia -c /Users/runner/work/aws-crt-cpp/aws-crt-cpp/aws-crt-cpp/crt/aws-c-io/source/darwin/nw_socket.c -o /Users/runner/work/aws-crt-cpp/aws-crt-cpp/aws-crt-cpp/build/aws-crt-cpp/build/aws-c-io.build/RelWithDebInfo-iphoneos/Objects-normal/arm64/nw_socket.o
/Users/runner/work/aws-crt-cpp/aws-crt-cpp/aws-crt-cpp/crt/aws-c-io/source/darwin/nw_socket.c:520:62: error: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'uint32_t' (aka 'unsigned int') [-Werror,-Wshorten-64-to-32]
        nw_tcp_options_set_maximum_segment_size(tcp_options, g_aws_channel_max_fragment_size);
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/runner/work/aws-crt-cpp/aws-crt-cpp/aws-crt-cpp/crt/aws-c-io/source/darwin/nw_socket.c:619:55: error: implicit conversion loses integer precision: 'CFIndex' (aka 'long') to 'int' [-Werror,-Wshorten-64-to-32]
        int crt_error_code = s_determine_socket_error(CFErrorGetCode(error));

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.74%. Comparing base (d8c88fe) to head (07083e6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #733   +/-   ##
=======================================
  Coverage   78.74%   78.74%           
=======================================
  Files          30       30           
  Lines        6385     6385           
=======================================
  Hits         5028     5028           
  Misses       1357     1357           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@waahm7 waahm7 merged commit 689dee3 into main May 21, 2025
50 checks passed
@waahm7 waahm7 deleted the fix-warnings-nw branch May 21, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants