Skip to content

Remove unused variables in aws_host_resolver #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graebm merged 3 commits into from
Mar 28, 2025
Merged

Remove unused variables in aws_host_resolver #719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
daa756d
Remove some old unused variables
graebm Mar 27, 2025
8190c6d
found some more
graebm Mar 28, 2025
9f113ae
Merge branch 'main' into dns-cruft
graebm Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions include/aws/io/host_resolver.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,6 @@ struct aws_host_resolution_config {
uint64_t resolve_frequency_ns; /* 0 defaults to 1 second interval */
};

struct aws_host_listener;

struct aws_host_listener_options;

struct aws_host_resolver_purge_host_options {
/* the host to purge the cache for */
const struct aws_string *host;
Expand Down
16 changes: 0 additions & 16 deletions source/host_resolver.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,15 +128,6 @@ struct default_host_resolver {
/* host_name (aws_string*) -> host_entry* */
struct aws_hash_table host_entry_table;

/* Hash table of listener entries per host name. We keep this decoupled from the host entry table to allow for
* listeners to be added/removed regardless of whether or not a corresponding host entry exists.
*
* Any time the listener list in the listener entry becomes empty, we remove the entry from the table. This
* includes when a resolver thread moves all of the available listeners to its local list.
*/
/* host_name (aws_string*) -> host_listener_entry* */
struct aws_hash_table listener_entry_table;

enum default_resolver_state state;

/*
Expand Down Expand Up @@ -329,7 +320,6 @@ static void s_cleanup_default_resolver(struct aws_host_resolver *resolver) {

aws_event_loop_group_release(default_host_resolver->event_loop_group);
aws_hash_table_clean_up(&default_host_resolver->host_entry_table);
aws_hash_table_clean_up(&default_host_resolver->listener_entry_table);

aws_mutex_clean_up(&default_host_resolver->resolver_lock);

Expand Down Expand Up @@ -923,12 +913,6 @@ static void aws_host_resolver_thread(void *arg) {
request_interruptible_wait_time = wait_between_resolves_interval - shutdown_only_wait_time;
}

struct aws_linked_list listener_list;
aws_linked_list_init(&listener_list);

struct aws_linked_list listener_destroy_list;
aws_linked_list_init(&listener_destroy_list);

bool keep_going = true;

struct aws_array_list address_list;
Expand Down