Fixed fragmentation bugs for secure channel, alpn no longer fails the… #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… negotiation if one of the endpoints didn't negotiate.
Contributor
Author
|
note, this does not address the happyeyeballs bug, I'll do that one in another pass. |
graebm
approved these changes
Mar 15, 2019
justinboswell
approved these changes
Mar 15, 2019
…e fragmentation fixes for securechannel.
justinboswell
approved these changes
Mar 16, 2019
graebm
reviewed
Mar 16, 2019
| any extra buffers left over, in the last phase, we then go ahead and send the output. This state function will | ||
| always say BLOCKED_ON_READ or SUCCESS. There will never be left over reads.*/ | ||
| do { | ||
| has_extra = false; |
Contributor
There was a problem hiding this comment.
[trivial debatable] while loops are easier to grok, could be:
bool has_more = true;
while (has_more) {
has_more = false;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… negotiation if one of the endpoints didn't negotiate.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.