Adds more stats. #358
Merged
Adds more stats. #358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmarsuhail
had a problem deploying
to
integration-tests
GitHub Actions
Failure
ahmarsuhail
had a problem deploying
to
integration-tests
GitHub Actions
Failure
ahmarsuhail
had a problem deploying
to
integration-tests
GitHub Actions
Failure
ahmarsuhail
had a problem deploying
to
integration-tests
GitHub Actions
Failure
ahmarsuhail
had a problem deploying
to
integration-tests
GitHub Actions
Failure
4 tasks
ahmarsuhail
had a problem deploying
to
integration-tests
GitHub Actions
Failure
ahmarsuhail
had a problem deploying
to
integration-tests
GitHub Actions
Failure
ahmarsuhail
had a problem deploying
to
integration-tests
GitHub Actions
Failure
ahmarsuhail
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
stubz151
approved these changes
Oct 14, 2025
Contributor
stubz151
left a comment
stubz151
left a comment
There was a problem hiding this comment.
lgtm, just 2 minor comments.
| } | ||
|
|
||
| @Test | ||
| void testContains() { |
Contributor
There was a problem hiding this comment.
I don't really get the point of this test
Collaborator
Author
There was a problem hiding this comment.
had to add it to ensure test coverage passes
| Math.max(maxReadLength, sequentialReadProgression.getSizeForGeneration(generation)); | ||
|
|
||
| // Record any range extension due to sequential prefetching | ||
| requestCallback.onBlockPrefetch(endPos + 1, truncatePos(pos + maxReadLength - 1)); |
Contributor
There was a problem hiding this comment.
can u explain this a bit more for me?
Collaborator
Author
There was a problem hiding this comment.
these are the number of extra bytes AAL requested that the user did not ask for.
the user request was for till endPos. And then AAL extended the request due to sequential prefetching, so we report these as prefetched bytes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Adds in support for some additional statistics
I want to add in some more stats around readVectored(), but will do that once the request coalescing PR is in.
Relevant issues
Does this contribution introduce any breaking changes to the existing APIs or behaviors?
Does this contribution introduce any new public APIs or behaviors?
How was the contribution tested?
Does this contribution need a changelog entry?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).