113 create script to publish custom metrics to cloudwatch#118
Merged
tmcallaghan merged 3 commits intomasterfrom May 22, 2024
Merged
Conversation
Contributor
|
I have reviewed and tested the code. @tmcallaghan can your merge with master |
tmcallaghan
requested changes
May 22, 2024
Contributor
tmcallaghan
left a comment
tmcallaghan
left a comment
There was a problem hiding this comment.
Please add minimum Python version check as per other scripts in the repo. Note this minumum version and the optional opt-out parameter in the readme.
| action='store_true', | ||
| help="log collection index size") | ||
|
|
||
| args = parser.parse_args() |
Contributor
There was a problem hiding this comment.
Add Python 3.7 minimum check with optional opt-out as in fl-multiprocess.py and other scripts in this repo.
Contributor
Author
There was a problem hiding this comment.
Added Python version check
tmcallaghan
deleted the
113-create-script-to-publish-custom-metrics-to-cloudwatch
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: 113
Description of changes: Added custom-metrics.py and README.md.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.