Skip to content

Conversation

@kmcginnes
Copy link
Collaborator

@kmcginnes kmcginnes commented Sep 22, 2025

Description

Removes the retry logic inside of the proxy server APIs.

The retry logic had a refetchMaxRetries default value of 1 and i < refetchMaxRetries. This meant only 0 is less than 1, resulting in a single execution of the for loop.

The client already has built in retries with Tanstack Query that we are dependent on. In addition, certain queries may require disabling the retry logic, which is only possible from the client. So retry logic in the server is not useful.

Validation

  • Tested across multiple databases
  • Tested against all three query languages

Related Issues

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0
    license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I have covered new added functionality with unit tests if necessary.
  • I have added an entry in the Changelog.md.

@kmcginnes kmcginnes force-pushed the sparql/remove-retry-logic branch 2 times, most recently from 6ff81f4 to c6444f1 Compare September 22, 2025 13:50
@kmcginnes kmcginnes force-pushed the sparql/remove-retry-logic branch from c6444f1 to dc749a0 Compare September 22, 2025 13:52
@kmcginnes kmcginnes marked this pull request as ready for review September 22, 2025 13:59
@kmcginnes kmcginnes marked this pull request as draft September 22, 2025 22:20
@kmcginnes
Copy link
Collaborator Author

Marking this as draft as I have some other cleanup work to do first and this is not necessary for SPARQL query editor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant