Skip to content

Updated EFA plugin version, added a new volume for EFA plugin to mount #1069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jchen6585 merged 1 commit into from
May 24, 2024
Merged

Updated EFA plugin version, added a new volume for EFA plugin to mount #1069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions stable/aws-efa-k8s-device-plugin/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
apiVersion: v1
name: aws-efa-k8s-device-plugin
description: A Helm chart for EFA device plugin.
version: v0.4.4
appVersion: "v0.4.4"
version: v0.5.1
appVersion: "v0.5.1"
home: https://github.com/aws/eks-charts
icon: https://raw.githubusercontent.com/aws/eks-charts/master/docs/logo/aws.png
sources:
Expand Down
7 changes: 6 additions & 1 deletion stable/aws-efa-k8s-device-plugin/templates/daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,12 @@ spec:
volumeMounts:
- name: device-plugin
mountPath: /var/lib/kubelet/device-plugins
- name: infiniband-volume
Copy link

@orsenthil orsenthil May 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.5.1. As part of this new version, the EFA plugin needs to be mounted to /dev/infiniband;

Could you share the reference to this?

Copy link
Contributor Author

@zachdorame zachdorame May 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the README in https://github.com/linux-rdma/rdma-core, we need to explicitly mount /dev/infiniband since that is where rdma-core accesses device nodes.

mountPath: /dev/infiniband/
volumes:
- name: device-plugin
hostPath:
path: /var/lib/kubelet/device-plugins
path: /var/lib/kubelet/device-plugins
- name: infiniband-volume
hostPath:
path: /dev/infiniband/
2 changes: 1 addition & 1 deletion stable/aws-efa-k8s-device-plugin/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
image:
repository: 602401143452.dkr.ecr.us-west-2.amazonaws.com/eks/aws-efa-k8s-device-plugin
# Overrides the image tag whose default is the chart appVersion.
tag: "v0.4.4"
tag: "v0.5.1"
securityContext:
allowPrivilegeEscalation: false
capabilities:
Expand Down