chore: allow copilot env init fallback to default credentials #5202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaptainCarpensir
requested review from
iamhopaul123
and removed request for
a team
|
🍕 Here are the new binary sizes!
|
Codecov Report
@@ Coverage Diff @@
## mainline #5202 +/- ##
=========================================
Coverage 69.52% 69.52%
=========================================
Files 295 295
Lines 43897 43902 +5
Branches 285 285
=========================================
+ Hits 30518 30523 +5
Misses 11889 11889
Partials 1490 1490
|
Lou1415926
reviewed
Aug 18, 2023
| errRetrieveCreds := err | ||
| sess, err := o.sessProvider.Default() | ||
| if err != nil { | ||
| return errors.Join(errRetrieveCreds, fmt.Errorf("falling back on default credentials: %w", err)) |
Contributor
There was a problem hiding this comment.
noice! It is a good call to include errRetrieveCreds in this case 👍🏼 !
iamhopaul123
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lets copilot fall back to default credentials when it fails to find/parse
.aws/configfile duringcopilot env init.Addresses #5066
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.