chore(pipeline): exit build stage if manifest validation failed #3080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| tag=$(sed 's/:/-/g' <<<"${CODEBUILD_BUILD_ID##*:}-${env}" | rev | cut -c 1-128 | rev) | ||
| for svc in $svcs; do | ||
| ./copilot-linux svc package -n $svc -e $env --output-dir './infrastructure' --tag $tag; | ||
| [ -s ./infrastructure/$svc-$env.params.json ] |
Contributor
There was a problem hiding this comment.
What does this mean 🤔
Contributor
Author
There was a problem hiding this comment.
It checks if a file is empty or not.
I've removed it, as we can just check the exit code from the svc package command.
iamhopaul123
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3072.
If a workload manifest fails, the pipeline build stage will fail, too, but only after many more steps, logs, and time. The validation error gets buried, and it isn't obvious that it's the cause of the failure.
This change checks if the
params.jsonfile that would be generated upon successful manifest validation is empty; if it is, the build exits with a suggestion to look for a manifest validation error message. There are, of course, still logs to wade through, but this should make the point of failure easier to pinpoint.Manually tested with invalid service manifest (ARM + Spot), valid service manifest, invalid job manifest (bad platform), valid job manifest.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.