Add tests for DynamoDBEntryConversion#3586
Merged
normj merged 2 commits intoaws:v4-developmentfrom Dec 20, 2024
Merged
Conversation
normj
approved these changes
Dec 20, 2024
Member
normj
left a comment
normj
left a comment
There was a problem hiding this comment.
Thanks for extra test coverage.
boblodgett
reviewed
Dec 20, 2024
sdk/test/Services/DynamoDBv2/UnitTests/Custom/DynamoDBEntryConversionTests.cs
Outdated
Show resolved
Hide resolved
Dreamescaper
force-pushed
the
add_tests_for_dynamodbentryconversion
branch
from
81169f0 to
c87701f
Compare
boblodgett
approved these changes
Dec 20, 2024
Member
|
Merged, thanks again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As discussed with @normj , submitting tests for DynamoDBEntryConversion separetely from PR #3300 .
Motivation and Context
Increase unit tests coverage.
I've added tests for conversion from and to DynamoDbEntry for both V1 and V2, for Primitives, Collections, Dictionaries.
Types of changes
Tests only, no functional changes.
Checklist
License