Avoid allocating byte[] just to convert to string#3425
Merged
normj merged 1 commit intoaws:v4-developmentfrom Aug 7, 2024
Merged
Avoid allocating byte[] just to convert to string#3425normj merged 1 commit intoaws:v4-developmentfrom
normj merged 1 commit intoaws:v4-developmentfrom
Conversation
Added System.Buffers to StringUtils.cs. Refactored FromMemoryStream to use MemoryStream.TryGetBuffer and ArrayPool<byte> for efficient memory handling. Modified FromString method signature without changing implementation. Made minor formatting changes in FromValueTypeList and headerListEntry processing logic to enhance readability.
normj
approved these changes
Aug 6, 2024
peterrsongg
approved these changes
Aug 7, 2024
Member
|
Thank you for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Amazon.Runtime.Internal.Util.StringUtils.FromMemoryStreamallocates abyte[]just to invokeConvert.ToBase64String.Description
If the user provided a
MemoryStreaminstance exposing the internal buffer, the buffer can be directly accessed and the data doesn't need to be copied.If not, pooled memory can be used.
Motivation and Context
Reduce allocations and memory copying.
Testing
All existing tests in
AWSSDK.CoreAndCustomUnitTests.NetStandardran successfully.Screenshots (if appropriate)
Types of changes
Checklist
License
/cc @normj