Optimize ParameterAsString#3363
Merged
dscpinheiro merged 2 commits intoaws:v4-developmentfrom Jul 4, 2024
Merged
Conversation
Contributor
Author
|
I will add a test to check the before and after |
f333d4b to
f58bf76
Compare
Contributor
Author
|
@normj @dscpinheiro this is ready |
normj
approved these changes
Jul 4, 2024
Contributor
Author
|
FYI I will be going on vacation end of this week and probably become unresponsive for at least three weeks |
dscpinheiro
approved these changes
Jul 4, 2024
This was referenced Jul 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For now I continue a bit on the path to use ValueStringBuilder where StringBuilders are used. There is probably even more room for optimizations but it seems a low effort way to get some gains
Description
Motivation and Context
https://github.com/danielmarbach/aws-sdk-net-benchmarks/blob/main/ParameterAsString.cs
Testing
I have added a test that verifies the current functionality works and then applied the optimizations which still pass the same test
Screenshots (if appropriate)
Types of changes
Checklist
License