Replace custom implementation of CopyStream with CopyTo#3292
Merged
normj merged 1 commit intoaws:v4-developmentfrom Apr 22, 2024
Merged
Replace custom implementation of CopyStream with CopyTo#3292normj merged 1 commit intoaws:v4-developmentfrom
normj merged 1 commit intoaws:v4-developmentfrom
Conversation
normj
approved these changes
Apr 22, 2024
Member
normj
left a comment
There was a problem hiding this comment.
Approved now we are not target .NET Framework 3.5 and CopyTo always exist in all of V4's targets.
dscpinheiro
approved these changes
Apr 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces the custom implementation of CopyStream with the stream based
CopyTomethod that has more efficient implementations.Motivation and Context
Testing
I ran benchmarks against
MemoryStreamsince that seems to be the most used version ofStreamin the cases I quickly checked againstScreenshots (if appropriate)
https://github.com/danielmarbach/aws-sdk-net-benchmarks/blob/main/StreamCopy.cs
Types of changes
Checklist
License