fix(util-endpoints): check for entire resource-path being empty #6380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
approved these changes
Aug 12, 2024
gosar
reviewed
Aug 13, 2024
kuhe
approved these changes
Aug 13, 2024
…both delimiters This reverts commit 855f1fa. It'll be added, if needed, in a separate PR.
gosar
approved these changes
Aug 13, 2024
Contributor
gosar
left a comment
gosar
left a comment
There was a problem hiding this comment.
Ok to ship this to unblock failing test, but follow up on expected behavior for case like arn:aws:s3:us-west-2:123456789012:my:folder/my:file
Member
Author
PR #6387 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Refs: #6379 (comment)
Description
Check for entire resource-path being empty when parsing Arn
Testing
Unit and Endpoint tests are successful
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.