Skip to content

fix(middleware-sdk-s3): fix error with partially-read Node.js streams #6294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kuhe merged 1 commit into from
Jul 21, 2024
Merged

fix(middleware-sdk-s3): fix error with partially-read Node.js streams #6294

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/middleware-sdk-s3/src/throw-200-exceptions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,11 @@ export const throw200ExceptionsMiddleware =
return headStream(stream, MAX_BYTES_TO_INSPECT);
},
});
if (typeof bodyCopy?.destroy === "function") {
// discard partially-read Node.js Stream.
bodyCopy.destroy();
}

const bodyStringTail = config.utf8Encoder(bodyBytes.subarray(bodyBytes.length - 16));

// Throw on 200 response with empty body, legacy behavior allowlist.
Expand Down