Skip to content

service/s3/s3manager: Fix brittle Upload unit test #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasdel merged 1 commit into from
Apr 10, 2019
Merged

service/s3/s3manager: Fix brittle Upload unit test #288

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions service/s3/s3manager/upload_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,12 +268,12 @@ func TestUploadFailIfPartSizeTooSmall(t *testing.T) {
}

aerr := err.(awserr.Error)
if "ConfigError" != aerr.Code() {
t.Errorf("Expected %q, but received %q", "ConfigError", aerr.Code())
if e, a := "ConfigError", aerr.Code(); e != a {
t.Errorf("Expected %q, but received %q", e, a)
}

if strings.Contains("part size must be at least", aerr.Message()) {
t.Errorf("Expected string to contain %q, but received %q", "part size must be at least", aerr.Message())
if e, a := "part size must be at least", aerr.Message(); !strings.Contains(a, e) {
t.Errorf("expect %v to be in %v", e, a)
}
}

Expand Down