updating customizations/utils #9817
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks for this PR! We'll likely need to remove the forward-compatible test for cn-northwest-2 unless we reintroduce the old string prefix fallback behavior, since aws_partition should handle this but the current partitions data does not include that specific test case.
awscli/customizations/utils.py
Outdated
| return "aws" | ||
| loader = Loader() | ||
| endpoints_data = loader.load_data('endpoints') | ||
| resolver = EndpointResolver(endpoints_data) |
There was a problem hiding this comment.
I've been advised that we should prioritize using partitions.json over endpoints.json when possible. Rather than manually parsing partitions.json, we can leverage the existing aws_partition function from RuleSetStandardLibrary while still maintaining 'aws' as the default fallback:
from botocore.endpoint_provider import RuleSetStandardLibary
loader = Loader()
partitions_data = loader.load_data('partitions')
rule_lib = RuleSetStandardLibary(partitions_data)
partition_result = rule_lib.aws_partition(region.lower())
return partition_result['name']
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes: Using botocore to fecth partitions
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.