chore(mixins-preview): adding toDestination() to vended logs#36896
Open
ShadowCat567 wants to merge 5 commits intomainfrom
Open
chore(mixins-preview): adding toDestination() to vended logs#36896ShadowCat567 wants to merge 5 commits intomainfrom
toDestination() to vended logs#36896ShadowCat567 wants to merge 5 commits intomainfrom
Conversation
added 2 commits
February 4, 2026 10:42
Contributor
|
|
||||||||||||||
Contributor
|
|
||||||||||||||
mrgrain
reviewed
Feb 6, 2026
packages/@aws-cdk/mixins-preview/test/codegen/__snapshots__/logs-delivery.test.ts.snap
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for this change
This is partially to support cross account vended logs, partially because being able to provide a deliveryDestination arn to set up a delivery connection is useful.
Description of changes
toDestination()allows VendedLogs to accept anyCfnDeliveryDestinationand will create a log delivery with it to the source resource that is provided.Describe any new or updated permissions being added
N/A
Description of how you validated changes
Added unit and integration tests
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license