Skip to content

Conversation

@mazyu36
Copy link
Contributor

@mazyu36 mazyu36 commented Nov 1, 2025

Issue # (if applicable)

Closes #35847

Reason for this change

NoPasswordUser only supports the Redis engine, but the documentation incorrectly states that the default engine is VALKEY, creating a contradiction between the implementation and documentation. Since NoPasswordUser only works with Redis, the engine property should not be configurable for this user type.

Description of changes

  • Fixed the contradiction by removing the engine configuration option from NoPasswordUser.
  • The engine property was moved from the base user class to only the user types that actually support multiple engines (IamUserProps and PasswordUserProps).

Describe any new or updated permissions being added

No new or updated IAM permissions are being added with these changes.

Description of how you validated changes

  • Verified that all existing unit tests pass after the changes
  • Updated test cases to remove references to the now-removed engine property in NoPasswordUser tests

Checklist

BREAKING CHANGE: The engine property in NoPasswordUserProps has been removed.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team November 1, 2025 15:16
@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Nov 1, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.

✅ A exemption request has been requested. Please wait for a maintainer's review.

@mazyu36 mazyu36 changed the title fix(elasticache): the default engine for NoPasswordUser contradict in the docs fix(elasticache): the default engine for NoPasswordUser contradict in the docs Nov 2, 2025
@mazyu36
Copy link
Contributor Author

mazyu36 commented Nov 2, 2025

Exemption request: Only changes to the setting method of the property, sufficient with unit tests.

@aws-cdk-automation aws-cdk-automation added pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Nov 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

distinguished-contributor [Pilot] contributed 50+ PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

elasticache: the default engine for NoPasswordUser contradict in the docs

2 participants