chore(spec2cdk): ensure strings are passed to attributes #35911
+37
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #.
Reason for this change
In some languages for which jsii cannot properly generate unions like Go, if a user passes the wrong property (i.e an
ILayerRefinstead of anIRoleRef), the error message will be unclear:Description of changes
Add a check to ensure that all unions have been resolved to a string and throw an error if not, at runtime it will look like:
Description of how you validated changes
Ran locally, updated snapshot tests. Unit test will be added once the relationships are enabled for
lambda.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license