-
Notifications
You must be signed in to change notification settings - Fork 4.3k
docs(eks): fix heading levels for Auto Mode #34783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There are redundant headers ("Using Auto Mode" and "Node Pools" appear twice) |
|
I understand that it’s under the EKS Auto Mode section, but I think it’s okay to keep the header since it helps clarify the structure. I’ve decided to leave it as-is for now out of respect for the original. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
ozelalisen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull request has been modified.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
The heading levels for Auto Mode are inappropriate.
I think the Auto Mode sections would be better placed under
Provision Clustersto align with other node types.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license