Skip to content

Conversation

@mazyu36
Copy link
Contributor

@mazyu36 mazyu36 commented Jun 21, 2025

The heading levels for Auto Mode are inappropriate.
I think the Auto Mode sections would be better placed under Provision Clusters to align with other node types.

image

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team June 21, 2025 08:58
@github-actions github-actions bot added p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Jun 21, 2025
@azharu
Copy link

azharu commented Jun 21, 2025

There are redundant headers ("Using Auto Mode" and "Node Pools" appear twice)
Good explanation of the difference between aws-eks and aws-eks-v2 , Links to official documentation are valuable

@mazyu36
Copy link
Contributor Author

mazyu36 commented Jun 22, 2025

I understand that it’s under the EKS Auto Mode section, but I think it’s okay to keep the header since it helps clarify the structure. I’ve decided to leave it as-is for now out of respect for the original.
I’d like to wait and hear the maintainer’s opinion.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 23, 2025
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b21f857
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

ozelalisen
ozelalisen previously approved these changes Aug 27, 2025
Copy link
Member

@ozelalisen ozelalisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ozelalisen ozelalisen self-assigned this Aug 27, 2025
@mergify mergify bot dismissed ozelalisen’s stale review August 27, 2025 09:35

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Aug 27, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Aug 27, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 7ca6671 into aws:main Aug 27, 2025
18 checks passed
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants