Skip to content

feat(synthetics): syn-nodejs-puppeteer-10.0 as supported runtime #34241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

feat(synthetics): syn-nodejs-puppeteer-10.0 as supported runtime #34241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c210fbb
feat(synthetics): syn-nodejs-puppeteer-10.0 as supported runtime (#34…
pv-rudger Apr 24, 2025
15791d7
Merge remote-tracking branch 'upstream/main' into feat-synthetics-nod…
pv-rudger Apr 24, 2025
45d69dd
Resolve review comment.
pv-rudger Apr 27, 2025
e0b10d1
Update readme and tests according to the "aws-cdk-automation" comments
pv-rudger Apr 27, 2025
108c226
Update Integration Canary Test
pv-rudger Apr 27, 2025
0d442d5
Update snapshot, with 'yarn integ --update-on-failed --dry-run'
pv-rudger May 3, 2025
9368e46
Merge remote-tracking branch 'upstream/main' into feat-synthetics-nod…
pv-rudger May 3, 2025
8bd4275
Merge branch 'main' into feat-synthetics-nodejs-puppeteer-10.0
pv-rudger May 9, 2025
641dbf4
Merge branch 'main' into feat-synthetics-nodejs-puppeteer-10.0
pv-rudger May 19, 2025
9d77687
Merge branch 'main' into feat-synthetics-nodejs-puppeteer-10.0
pv-rudger Jun 23, 2025
8fd264e
Merge branch 'main' into feat-synthetics-nodejs-puppeteer-10.0
aemada-aws Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
266 changes: 259 additions & 7 deletions ...ramework-integ/test/aws-synthetics/test/integ.canary.js.snapshot/canary-one.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@
]
},
"Name": "canaryoneinline66eeb2",
"RuntimeVersion": "syn-nodejs-puppeteer-7.0",
"RuntimeVersion": "syn-nodejs-puppeteer-10.0",
"Schedule": {
"DurationInSeconds": "0",
"Expression": "rate(1 minute)"
Expand Down Expand Up @@ -696,7 +696,7 @@
}
}
},
"RuntimeVersion": "syn-nodejs-puppeteer-7.0",
"RuntimeVersion": "syn-nodejs-puppeteer-10.0",
"Schedule": {
"DurationInSeconds": "0",
"Expression": "rate(5 minutes)"
Expand Down Expand Up @@ -943,7 +943,7 @@
}
}
},
"RuntimeVersion": "syn-nodejs-puppeteer-7.0",
"RuntimeVersion": "syn-nodejs-puppeteer-10.0",
"Schedule": {
"DurationInSeconds": "0",
"Expression": "rate(5 minutes)"
Expand Down Expand Up @@ -1170,7 +1170,7 @@
]
},
"Name": "canaryonezipass32aaf5",
"RuntimeVersion": "syn-nodejs-puppeteer-7.0",
"RuntimeVersion": "syn-nodejs-puppeteer-10.0",
"Schedule": {
"DurationInSeconds": "0",
"Expression": "rate(5 minutes)"
Expand Down Expand Up @@ -2682,6 +2682,253 @@
"UpdateReplacePolicy": "Delete",
"DeletionPolicy": "Delete"
},
"SynNodejsPuppeteer100ArtifactsBucket18CB3FC5": {
"Type": "AWS::S3::Bucket",
"Properties": {
"BucketEncryption": {
"ServerSideEncryptionConfiguration": [
{
"ServerSideEncryptionByDefault": {
"SSEAlgorithm": "aws:kms"
}
}
]
}
},
"UpdateReplacePolicy": "Retain",
"DeletionPolicy": "Retain"
},
"SynNodejsPuppeteer100ArtifactsBucketPolicy01646566": {
"Type": "AWS::S3::BucketPolicy",
"Properties": {
"Bucket": {
"Ref": "SynNodejsPuppeteer100ArtifactsBucket18CB3FC5"
},
"PolicyDocument": {
"Statement": [
{
"Action": "s3:*",
"Condition": {
"Bool": {
"aws:SecureTransport": "false"
}
},
"Effect": "Deny",
"Principal": {
"AWS": "*"
},
"Resource": [
{
"Fn::GetAtt": [
"SynNodejsPuppeteer100ArtifactsBucket18CB3FC5",
"Arn"
]
},
{
"Fn::Join": [
"",
[
{
"Fn::GetAtt": [
"SynNodejsPuppeteer100ArtifactsBucket18CB3FC5",
"Arn"
]
},
"/*"
]
]
}
]
}
],
"Version": "2012-10-17"
}
}
},
"SynNodejsPuppeteer100ServiceRoleD6FEE637": {
"Type": "AWS::IAM::Role",
"Properties": {
"AssumeRolePolicyDocument": {
"Statement": [
{
"Action": "sts:AssumeRole",
"Effect": "Allow",
"Principal": {
"Service": "lambda.amazonaws.com"
}
}
],
"Version": "2012-10-17"
},
"Policies": [
{
"PolicyDocument": {
"Statement": [
{
"Action": "s3:ListAllMyBuckets",
"Effect": "Allow",
"Resource": "*"
},
{
"Action": "s3:GetBucketLocation",
"Effect": "Allow",
"Resource": {
"Fn::GetAtt": [
"SynNodejsPuppeteer100ArtifactsBucket18CB3FC5",
"Arn"
]
}
},
{
"Action": "s3:PutObject",
"Effect": "Allow",
"Resource": {
"Fn::Join": [
"",
[
{
"Fn::GetAtt": [
"SynNodejsPuppeteer100ArtifactsBucket18CB3FC5",
"Arn"
]
},
"/*"
]
]
}
},
{
"Action": "cloudwatch:PutMetricData",
"Condition": {
"StringEquals": {
"cloudwatch:namespace": "CloudWatchSynthetics"
}
},
"Effect": "Allow",
"Resource": "*"
},
{
"Action": [
"logs:CreateLogGroup",
"logs:CreateLogStream",
"logs:PutLogEvents"
],
"Effect": "Allow",
"Resource": {
"Fn::Join": [
"",
[
"arn:",
{
"Ref": "AWS::Partition"
},
":logs:",
{
"Ref": "AWS::Region"
},
":",
{
"Ref": "AWS::AccountId"
},
":log-group:/aws/lambda/cwsyn-*"
]
]
}
}
],
"Version": "2012-10-17"
},
"PolicyName": "canaryPolicy"
}
]
}
},
"SynNodejsPuppeteer1000EA980A1": {
"Type": "AWS::Synthetics::Canary",
"Properties": {
"ArtifactS3Location": {
"Fn::Join": [
"",
[
"s3://",
{
"Ref": "SynNodejsPuppeteer100ArtifactsBucket18CB3FC5"
}
]
]
},
"Code": {
"Handler": "canary.handler",
"S3Bucket": {
"Fn::Sub": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}"
},
"S3Key": "5178413cfe8db00b2d5dcfa9be417e934c64601d0da3031d88c145c8293bc27f.zip"
},
"ExecutionRoleArn": {
"Fn::GetAtt": [
"SynNodejsPuppeteer100ServiceRoleD6FEE637",
"Arn"
]
},
"Name": "canaryonesynnod37bb77",
"RunConfig": {
"EnvironmentVariables": {
"URL": {
"Fn::Join": [
"",
[
"https://",
{
"Ref": "ApiGateway11E7F47B"
},
".execute-api.",
{
"Ref": "AWS::Region"
},
".",
{
"Ref": "AWS::URLSuffix"
},
"/",
{
"Ref": "ApiGatewayDeploymentStageprod1C6D5CD6"
},
"/"
]
]
}
}
},
"RuntimeVersion": "syn-nodejs-puppeteer-10.0",
"Schedule": {
"DurationInSeconds": "0",
"Expression": "rate(5 minutes)"
},
"StartCanaryAfterCreation": true,
"Tags": [
{
"Key": "aws-cdk:auto-delete-underlying-resources",
"Value": "true"
}
]
}
},
"SynNodejsPuppeteer100AutoDeleteUnderlyingResourcesCustomResource3C0A7AE6": {
"Type": "Custom::SyntheticsAutoDeleteUnderlyingResources",
"Properties": {
"ServiceToken": {
"Fn::GetAtt": [
"CustomSyntheticsAutoDeleteUnderlyingResourcesCustomResourceProviderHandler26776D4E",
"Arn"
]
},
"CanaryName": {
"Ref": "SynNodejsPuppeteer1000EA980A1"
}
},
"UpdateReplacePolicy": "Delete",
"DeletionPolicy": "Delete"
},
"SynNodejsPlaywright10ArtifactsBucket0BEF234F": {
"Type": "AWS::S3::Bucket",
"Properties": {
Expand Down Expand Up @@ -5519,9 +5766,6 @@
"us-isob-east-1": {
"value": "nodejs18.x"
},
"us-isob-west-1": {
"value": "nodejs18.x"
},
"us-west-1": {
"value": "nodejs22.x"
},
Expand Down Expand Up @@ -5637,6 +5881,14 @@
"Name": "canary-one:ExportsOutputRefSynNodejsPuppeteer9117CE212DF6A4C93F"
}
},
"ExportsOutputRefSynNodejsPuppeteer1000EA980A151AC01E3": {
"Value": {
"Ref": "SynNodejsPuppeteer1000EA980A1"
},
"Export": {
"Name": "canary-one:ExportsOutputRefSynNodejsPuppeteer1000EA980A151AC01E3"
}
},
"ExportsOutputRefSynNodejsPlaywright109DE126CABF4DC65C": {
"Value": {
"Ref": "SynNodejsPlaywright109DE126CA"
Expand Down
11 changes: 7 additions & 4 deletions packages/@aws-cdk-testing/framework-integ/test/aws-synthetics/test/integ.canary.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ const inlineAsset = new Canary(stack, 'InlineAsset', {
}),
schedule: Schedule.rate(cdk.Duration.minutes(1)),
artifactsBucketLocation: { bucket, prefix },
runtime: Runtime.SYNTHETICS_NODEJS_PUPPETEER_7_0,
runtime: Runtime.SYNTHETICS_NODEJS_PUPPETEER_10_0,
cleanup: Cleanup.LAMBDA,
});

Expand All @@ -49,7 +49,7 @@ const directoryAsset = new Canary(stack, 'DirectoryAsset', {
handler: 'canary.handler',
code: Code.fromAsset(path.join(__dirname, 'canaries')),
}),
runtime: Runtime.SYNTHETICS_NODEJS_PUPPETEER_7_0,
runtime: Runtime.SYNTHETICS_NODEJS_PUPPETEER_10_0,
environmentVariables: {
URL: api.url,
},
Expand All @@ -61,7 +61,7 @@ const folderAsset = new Canary(stack, 'FolderAsset', {
handler: 'folder/canary.functionName',
code: Code.fromAsset(path.join(__dirname, 'canaries')),
}),
runtime: Runtime.SYNTHETICS_NODEJS_PUPPETEER_7_0,
runtime: Runtime.SYNTHETICS_NODEJS_PUPPETEER_10_0,
environmentVariables: {
URL: api.url,
},
Expand All @@ -78,7 +78,7 @@ const zipAsset = new Canary(stack, 'ZipAsset', {
expiration: cdk.Duration.days(30),
},
],
runtime: Runtime.SYNTHETICS_NODEJS_PUPPETEER_7_0,
runtime: Runtime.SYNTHETICS_NODEJS_PUPPETEER_10_0,
cleanup: Cleanup.LAMBDA,
});

Expand All @@ -102,6 +102,8 @@ const puppeteer70 = createCanaryByRuntimes(Runtime.SYNTHETICS_NODEJS_PUPPETEER_7
const puppeteer80 = createCanaryByRuntimes(Runtime.SYNTHETICS_NODEJS_PUPPETEER_8_0);
const puppeteer90 = createCanaryByRuntimes(Runtime.SYNTHETICS_NODEJS_PUPPETEER_9_0);
const puppeteer91 = createCanaryByRuntimes(Runtime.SYNTHETICS_NODEJS_PUPPETEER_9_1);
const puppeteer10 = createCanaryByRuntimes(Runtime.SYNTHETICS_NODEJS_PUPPETEER_10_0);

const playwright10 = createCanaryByRuntimes(Runtime.SYNTHETICS_NODEJS_PLAYWRIGHT_1_0);
const playwright10_with_handler_name = createCanaryByRuntimes(Runtime.SYNTHETICS_NODEJS_PLAYWRIGHT_1_0, 'playwright/canary.handler');
const playwright20 = createCanaryByRuntimes(Runtime.SYNTHETICS_NODEJS_PLAYWRIGHT_2_0);
Expand Down Expand Up @@ -131,6 +133,7 @@ const test = new IntegTest(app, 'IntegCanaryTest', {
puppeteer80,
puppeteer90,
puppeteer91,
puppeteer10,
playwright10,
playwright10_with_handler_name,
playwright20,
Expand Down
Loading
Loading