Skip to content

chore: rename away more _ identifiers#25481

Merged
mergify[bot] merged 2 commits into
mainfrom
huijbers/more-underscores
May 8, 2023
Merged

chore: rename away more _ identifiers#25481
mergify[bot] merged 2 commits into
mainfrom
huijbers/more-underscores

Conversation

@rix0rrr
Copy link
Copy Markdown
Contributor

@rix0rrr rix0rrr commented May 8, 2023

_ identifiers cause a problem with Java compilation. Remove them.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

`_` identifiers cause a problem with Java compilation. Remove them.
@rix0rrr rix0rrr requested a review from a team May 8, 2023 12:15
@gitpod-io
Copy link
Copy Markdown

gitpod-io Bot commented May 8, 2023

@aws-cdk-automation aws-cdk-automation requested a review from a team May 8, 2023 12:15
@github-actions github-actions Bot added the p2 label May 8, 2023
@mergify mergify Bot added the contribution/core This is a PR that came from AWS. label May 8, 2023
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented May 8, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 8, 2023
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 7db9b07
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify Bot merged commit 1f4c4fa into main May 8, 2023
@mergify mergify Bot deleted the huijbers/more-underscores branch May 8, 2023 13:04
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented May 8, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants