Skip to content

Comments

feat: support control plane flag to turn off the controller#544

Merged
haouc merged 2 commits intoaws:masterfrom
haouc:master
Apr 13, 2025
Merged

feat: support control plane flag to turn off the controller#544
haouc merged 2 commits intoaws:masterfrom
haouc:master

Conversation

@haouc
Copy link
Contributor

@haouc haouc commented Apr 11, 2025

Issue #, if available:

Description of changes:
We want to support disable the controller if none of SGP and Windows are required. The disable flag should be passed from EKS managed services. After the controller is disabled, the lightly loaded controller will only run

  • Network Interface cleanup
  • Webhooks uninstaller
  • Possible CNINode leaked resources cleanup

This change will add a new metric for enabled/disabled controller.

The change has been tested with integrations and cleanup tests.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@haouc haouc requested a review from a team as a code owner April 11, 2025 06:07
@haouc haouc changed the title support control plane flag to turn off the controller feat: support control plane flag to turn off the controller Apr 11, 2025
Copy link
Contributor

@yash97 yash97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@haouc haouc merged commit d12c689 into aws:master Apr 13, 2025
4 checks passed
haouc added a commit to haouc/amazon-vpc-resource-controller-k8s that referenced this pull request Apr 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants