feat(shell): Parameterize binary names in shell integration scripts #862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add {{CLI_BINARY_NAME}} and {{PTY_BINARY_NAME}} placeholders to all shell scripts
- Update pre.sh, pre.fish, pre.nu to use placeholders
- Update post.bash, post.fish, post.zsh, post.nu to use placeholders
- Modify get_fig_integration_source() to return String and perform substitution
- Replace hardcoded 'q' and 'qterm' with constants from fig_util::consts
- Remove unnecessary .into() call in init.rs
This enables easy rebranding by changing constants in one place.
akhileshb
approved these changes
Oct 29, 2025
brandonskiser
approved these changes
Oct 29, 2025
- Add {{CLI_BINARY_NAME}} and {{CLI_BINARY_NAME_UPPER}} placeholders to all inline shell completion .zsh files
- Update build.rs to perform runtime substitution of placeholders
- Replace all _q_ function prefixes with _{{CLI_BINARY_NAME}}_
- Replace all _Q_ and Q_ variable prefixes with _{{CLI_BINARY_NAME_UPPER}}_ and {{CLI_BINARY_NAME_UPPER}}_
- Replace hardcoded 'q' binary commands with {{CLI_BINARY_NAME}}
- Add CLI_BINARY_NAME constant at top of build.rs
This enables changing binary names by updating constants in one place.
| const CODEX_FOLDER: &str = "src/shell/inline_shell_completion"; | ||
|
|
||
| // Binary name constants for parameterization | ||
| const CLI_BINARY_NAME: &str = "q"; |
Contributor
There was a problem hiding this comment.
Can fig_util be a build dependency, so we don't have to duplicate it here?
crates/fig_integrations/build.rs
Outdated
| } | ||
|
|
||
| // Substitute placeholders with actual binary names | ||
| let cli_binary_name_upper = CLI_BINARY_NAME.to_uppercase(); |
Contributor
There was a problem hiding this comment.
What if the binary name has a - in it? Should we also replace - with _?
- Add fig_util as build-dependency to access CLI_BINARY_NAME constant
- Introduce CLI_BINARY_NAME_UNDERSCORE placeholder for function names (handles hyphens)
- Replace _{{CLI_BINARY_NAME}}_ with _{{CLI_BINARY_NAME_UNDERSCORE}}_ in all function names
- Keep {{CLI_BINARY_NAME}} for actual binary command usage
- Update build.rs to convert hyphens to underscores for function names
- Update test to use underscore version for function name checks
kkashilk
force-pushed
the
parameterize-remaining
branch
from
2df7690 to
2e752c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.