Make block I/O stat Op parsing case insensitive#4836
Merged
Conversation
a8c5484 to
56d9868
Compare
singholt
reviewed
Jan 7, 2026
singholt
previously approved these changes
Jan 7, 2026
56d9868 to
2a5b461
Compare
prateekchaudhry
previously approved these changes
Jan 7, 2026
singholt
previously approved these changes
Jan 7, 2026
2de35c5
2a5b461 to
2de35c5
Compare
singholt
approved these changes
Jan 7, 2026
prateekchaudhry
approved these changes
Jan 7, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make logic that parses block I/O
Opfromdocker statscase insensitive.This is because
docker statscould return values ofOpwhich may or may not have consistent capitalization (for example, Docker returns values ofOpsuch as "read" and "write" for cgroups v2 as opposed to "Read" and "Write" for cgroups v1). Thus, without the change in this pull request, ECS Agent currently is susceptible to potentially ignore data that it actually should take it into account for storage metrics that ECS surfaces to CloudWatch.Implementation details
See "Summary" section above.
Testing
New tests cover the changes: yes (new unit test added and existing integ test updated)
Manually performed the following end to end test:
Description for the changelog
Bugfix - Make block I/O stat Op parsing case insensitive
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
No
Does this PR include the addition of new environment variables in the README?
No
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.