Skip to content

Update prometheus-eks.yaml to include cluster_name and region_name#182

Open
soumyabavirisetti wants to merge 1 commit into
aws-samples:mainfrom
soumyabavirisetti:patch-1
Open

Update prometheus-eks.yaml to include cluster_name and region_name#182
soumyabavirisetti wants to merge 1 commit into
aws-samples:mainfrom
soumyabavirisetti:patch-1

Conversation

@soumyabavirisetti

@soumyabavirisetti soumyabavirisetti commented Feb 3, 2025

Copy link
Copy Markdown

The "cluster_name" and "region_name" not specified in the prometheus-eks.yaml. So if customers use this yaml, they'll face the below error :

2025/02/03 11:00:06 E! Failed to generate TOML configuration validation content: [Under path : /agent/ruleRegion/ | Error : Region info is missing for mode: onPrem Under path : /logs/metrics_collected/prometheus/ | Error : ClusterName is not defined] 2025/02/03 11:00:06 Under path : /agent/ruleRegion/ | Error : Region info is missing for mode: onPrem 2025/02/03 11:00:06 Under path : /logs/metrics_collected/prometheus/ | Error : ClusterName is not defined 

Description of the issue

Describe the problem or feature in addition to a link to the issues.

Description of changes

How does this change address the problem?

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tests

Describe what tests you have done.

Requirements

Before committing the code, please verify the following:

  • If this commit includes changes to existing sample configurations, you acknowledge that you have confirmed this will not impact existing customer behavior.
  • If not necessary, consider creating a new sample configuration for this change.

cluster_name and region_name not specified in the yaml. So if customers use this yaml, they'll face the below error :

~~~~
2025/02/03 11:00:06 E! Failed to generate TOML configuration validation content: [Under path : /agent/ruleRegion/ | Error : Region info is missing for mode: onPrem Under path : /logs/metrics_collected/prometheus/ | Error : ClusterName is not defined]
2025/02/03 11:00:06 Under path : /agent/ruleRegion/ | Error : Region info is missing for mode: onPrem
2025/02/03 11:00:06 Under path : /logs/metrics_collected/prometheus/ | Error : ClusterName is not defined
~~~~
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant