Skip to content

Conversation

@KlwntSingh
Copy link
Contributor

  1. Update script to include Windows
  2. Update CW agent daemonset yaml to include recent change in helm charts

Description of the issue

Manifest udpate script doesn't update Windows daemonset yamls during new releases.

Description of changes

  1. This change update manifest update script to include windows daemonset.
  2. Windows daemonset are updated to include workDir change similar to change in helm charts.

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tests

  1. Ran script locally to update daemonset yamls and it works as expected.
Screenshot 2024-05-22 at 12 34 31 PM 2. Windows daemonset update with `workDir` field was tested during helm chart change https://github.com/aws-observability/helm-charts/actions/runs/8816835391

Requirements

Before committing the code, please verify the following:

  • If this commit includes changes to existing sample configurations, you acknowledge that you have confirmed this will not impact existing customer behavior.
  • If not necessary, consider creating a new sample configuration for this change.

1. Update script to include Windows
2. Update CW agent daemonset yaml to include recent change in helm charts
@KlwntSingh KlwntSingh merged commit 7cada79 into aws-samples:main May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants