Small edits to Soak Tests #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
reviewed
Sep 27, 2021
| shutil.rmtree(old_snapshots_dir, ignore_errors=True) | ||
| # Delete oldest run folders in most recent commit and oldest commit folders | ||
|
|
||
| for snapshots_dir in [ |
Contributor
There was a problem hiding this comment.
Can you split the change to auth and the other edits into separate PRs?
NathanielRN
force-pushed
the
edits-to-soak-tests
branch
from
ab1e44b to
c38ac82
Compare
anuraaga
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #84, we make some small edits to the Soak Tests:
commits/<current_commit_id>/runs/folder as well as thecommits/folder.Fix authentication by usingMoved to Use STS get-session-token for short lived AWS authentication with OIDC #88aws sts get-session-tokeninstead of GitHub OIDC. This is because we found that the OIDC token expires after 5 minutes, and Soak Tests might not refresh until 10 or 40 minutes later. That's why for Soak Tests specifically we need this different way of using "temporary credentials".It would be interesting to check in the future if usingaws sts get-session-tokenallow us to remove theAWS_ACCESS_KEY_IDandAWS_SECRET_ACCESS_KEYsecrets.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.