[Enhancement] Add ability to provide a list of Availability Zones for subnet placement #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for providing specific az's to use by providing variable `azs` as a substitute for `az_count`. Use case is when customers wish to deploy the VPC in specific AZs where other services or service endpoints are deployed to optimize for cost and performance (latency). Signed-off-by: Adrian Begg <[email protected]>
- Added precondition and postcondition validators to ensure exactly one input provided and to validate azs provided - Added example for providing specific az use case Signed-off-by: Adrian Begg <[email protected]>
Signed-off-by: Adrian Begg <[email protected]>
Signed-off-by: Adrian Begg <[email protected]>
AdrianBegg
requested review from
a team,
andrew-glenn,
tlindsay42 and
tonynv
as code owners
Member
|
@AdrianBegg reminder to fix up the merge conflict |
Contributor
Author
|
Thanks @tlindsay42 for the reminder 👍 have fixed up the conflict and should hopefully be ready for review |
pablo19sc
previously approved these changes
Aug 11, 2023
Collaborator
pablo19sc
left a comment
pablo19sc
left a comment
There was a problem hiding this comment.
Looks amazing! Thanks @AdrianBegg for this!
|
Looks like this is pending review for quite some time. Any chance we can get this merged? Like new conflicts since @AdrianBegg fixed previously. |
Collaborator
|
Hi! I will work today in resolving conflicts and merging - just waiting to have a minor fix merge first. Sorry for the delay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #123