Skip to content

Update to ACK runtime v0.56.0, code-generator v0.56.0#61

Merged
ack-prow[bot] merged 1 commit intomainfrom
ack-bot/rt-v0.56.0-codegen-v0.56.0
Nov 29, 2025
Merged

Update to ACK runtime v0.56.0, code-generator v0.56.0#61
ack-prow[bot] merged 1 commit intomainfrom
ack-bot/rt-v0.56.0-codegen-v0.56.0

Conversation

@ack-bot
Copy link
Collaborator

@ack-bot ack-bot commented Nov 29, 2025

Update to ACK runtime v0.56.0, code-generator v0.56.0



NOTE:
This PR increments the release version of service controller from v1.1.2 to v1.2.0

Once this PR is merged, release v1.2.0 will be automatically created for ssm-controller

Please close this PR, if you do not want the new patch release for ssm-controller


stdout for make build-controller:

building ack-generate ... ok.
==== building ssm-controller ====
Copying common custom resource definitions into ssm
Building Kubernetes API objects for ssm
Generating deepcopy code for ssm
Generating custom resource definitions for ssm
Building service controller for ssm
Running GO mod tidy
Generating RBAC manifests for ssm
Running gofmt against generated code for ssm
Updating additional GitHub repository maintenance files
==== building ssm-controller release artifacts ====
Building release artifacts for ssm-v1.2.0
Generating common custom resource definitions
Generating custom resource definitions for ssm
Generating RBAC manifests for ssm

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot added the prow/auto-gen PRs related to prow auto generation automation label Nov 29, 2025
@ack-prow ack-prow bot requested review from knottnt and michaelhtm November 29, 2025 03:47

jobs:
call-hydrate-go-proxy:
uses: aws-controllers-k8s/.github/.github/workflows/reusable-postsubmit.yaml@main

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}

Copilot Autofix

AI 3 months ago

To fix this issue, we should add an explicit permissions block at the top level of the workflow file. As per best practice, we should use the most restrictive set required. Since this workflow is delegating its job using uses: to a reusable workflow, there may not be a need for any write permissions at all. The minimal safe starting point is to use permissions: {} which disables all GITHUB_TOKEN permissions for the initial workflow and jobs unless specifically required. This block should be added after the name key or before the on block at the beginning of .github/workflows/postsubmit.yaml.


Suggested changeset 1
.github/workflows/postsubmit.yaml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/postsubmit.yaml b/.github/workflows/postsubmit.yaml
--- a/.github/workflows/postsubmit.yaml
+++ b/.github/workflows/postsubmit.yaml
@@ -1,4 +1,5 @@
 name: Hydrate Go Proxy
+permissions: {}
 
 on:
   push:
EOF
@@ -1,4 +1,5 @@
name: Hydrate Go Proxy
permissions: {}

on:
push:
Copilot is powered by AI and may make mistakes. Always verify output.
@a-hilaly
Copy link
Member

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2025
@ack-prow
Copy link

ack-prow bot commented Nov 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, ack-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label Nov 29, 2025
@ack-prow ack-prow bot merged commit ad09c0b into main Nov 29, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged. prow/auto-gen PRs related to prow auto generation automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants