Skip to content

Conversation

@jaypipes
Copy link
Collaborator

Adds logic to the resource managers for GlobalTable, Table and
Backup resources to properly understand when
ACK.ResourceSynced=True condition should be applied.

Issue aws-controllers-k8s/community#1500

Signed-off-by: Jay Pipes [email protected]

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

Adds logic to the resource managers for GlobalTable, Table and Backup
resources to properly understand when ACK.ResourceSynced=True condition
should be applied.

Issue aws-controllers-k8s/community#1500

Signed-off-by: Jay Pipes <[email protected]>
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat 👍

@a-hilaly
Copy link
Member

/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2022
@ack-bot
Copy link
Collaborator

ack-bot commented Oct 17, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, jaypipes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit ce5980c into aws-controllers-k8s:main Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants