fix: change syncTableTags parameter order to avoid panic #136
Conversation
In syncTableTags, there was an issue with the order/naming of desired vs latest resource. Although the function is called using `syncTableTags(desired, latest)` the function definition had `syncTableTags(latest, desired)`. This becomes an issue when we try to retrieve the ARN from latest, during adoption. Although in the funciton we named the parameter `latest`, this parameter was treated as the desired resource when computing the tags delta. During adoption, the Status/ARN of the desired resource is meant to be nil, unitl it is later populated. Hence our need to use the ARN from latest
|
@michaelhtm: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knottnt, michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 participants
Issue #2459#issuecomment-2886623397
Description of changes:
In syncTableTags, there was an issue with the order/naming of desired vs
latest resource.
Although the function is called using
syncTableTags(desired, latest)the function definition had
syncTableTags(latest, desired). Thisbecomes an issue when we try to retrieve the ARN from latest, during
adoption.
Although in the funciton we named the parameter
latest, this parameterwas treated as the desired resource when computing the tags delta.
During adoption, the Status/ARN of the desired resource is meant to be
nil, unitl it is later populated. Hence our need to use the ARN from
latest.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.