fix: Wrong ClusterRole name in caches ClusterRoleBinding#605
fix: Wrong ClusterRole name in caches ClusterRoleBinding#605ack-prow[bot] merged 1 commit intoaws-controllers-k8s:mainfrom
Conversation
|
Hi @vladmalynych. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
michaelhtm
left a comment
There was a problem hiding this comment.
Great catch @vladmalynych
/ok-to-test
|
/retest |
|
@knottnt Hi, can you please merge it, this blocks upgrade of ACKs deployed by helm. |
|
/retest |
|
@vladmalynych: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knottnt, vladmalynych The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fc0b91c
into
aws-controllers-k8s:main
Issue:
ClusterRoleBinding can not mount ClusterRole
ack-iam-iam-chart-namespace-cachesbecause it doesnt exist.Description of changes:
Fix the naming of ClusterRoleBinding and ClusterRole attached to it.
Fixes issue from PR:
#593
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.